Code flag to indicate a need to revisit the code / locate unfinished code?

Petter Reinholdtsen pere at hungry.com
Tue May 30 09:29:27 CEST 2017


[Thomas Sødring]
> First off, what you are seeing there is from very early on in
> implementation, you'll notice that it's searching by id, not systemID,
> so this is from the time it was unclear in the standard if we should
> use id or systemIDs to retrieve objects. It was also unclear if we
> should also be allowed to search by id. This method can safely be
> deleted.

OK.  But I believe we should start by flagging all such issues in a way
that allow us to count their number, to actually see that the amount is
shrinking, before we start removing the code.

> If you search for TODO: you will probably find what I didn' t get
> around to doing.  There are many, but they are shrinking .

So you have been using TODO as such flag already?  I find 60 lines with
'TODO' in core-*.

> I did consider using the following.
>   https://github.com/Stuie/papercut
> I do like the approach here.

Look useful, but perhaps a bit overkill?

> Perhaps we should try and include papercut, but I am trying to
> introduce finished blocks of code, rather then half blocks.

I am reluctant to introduce more dependencies, espesially those not
already in Debian, as it make it harder to get the API implementation
into Debian and other linux distributions.

What if we stick with TODO for now, and consider transforming them to
the papercut notation when we have a more complete picture?

-- 
Happy hacking
Petter Reinholdtsen


More information about the nikita-noark mailing list