<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Arial,Helvetica,sans-serif">
<p>Hi,</p>
<p><br>
</p>
<p>I don't need to introduce papercut, I just thought it was interesting in relation to your question. I'm a bit wary of annotations, as I see that sometimes they are a lot more than what meets the eye. I'd like to keep the codebase as clean as possible. The
last while I've quietly been removing the @Autowired annotation and gone back to more classic Dependency Injection to keep nikita more in line with JavaEE than spring.</p>
<p><br>
</p>
<p>I would have thought there was more than 60 TODOs but perhaps that's a good starting point. Some of them are probably in code that can be removed.</p>
<p><br>
</p>
<p>I agree, that we continue with TODO and have a go looking at them. I'm bogged down with other stuff at the moment so don't have time to look at it, but when we have a round on fixing stuff that coverity finds, maybe we could start removing TODOs aswell.</p>
<p><br>
</p>
<p>Quietly the last while I've also been making sure java files have no warnings. When I'm working a file I Iook at the warnings Idea is telling me and do my best to remove all of them. I'm seeing some warnings for methods that are never called so that's a
good place to look for potential bugs.</p>
<p><br>
</p>
<p> - Tom</p>
<p><br>
</p>
<p></p>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> nikita-noark-bounces@nuug.no <nikita-noark-bounces@nuug.no> on behalf of Petter Reinholdtsen <pere@hungry.com><br>
<b>Sent:</b> Tuesday, May 30, 2017 9:29:27 AM<br>
<b>To:</b> nikita-noark@nuug.no<br>
<b>Subject:</b> Re: Code flag to indicate a need to revisit the code / locate unfinished code?</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">[Thomas Sødring]<br>
> First off, what you are seeing there is from very early on in<br>
> implementation, you'll notice that it's searching by id, not systemID,<br>
> so this is from the time it was unclear in the standard if we should<br>
> use id or systemIDs to retrieve objects. It was also unclear if we<br>
> should also be allowed to search by id. This method can safely be<br>
> deleted.<br>
<br>
OK. But I believe we should start by flagging all such issues in a way<br>
that allow us to count their number, to actually see that the amount is<br>
shrinking, before we start removing the code.<br>
<br>
> If you search for TODO: you will probably find what I didn' t get<br>
> around to doing. There are many, but they are shrinking .<br>
<br>
So you have been using TODO as such flag already? I find 60 lines with<br>
'TODO' in core-*.<br>
<br>
> I did consider using the following.<br>
> <a href="https://github.com/Stuie/papercut">https://github.com/Stuie/papercut</a><br>
> I do like the approach here.<br>
<br>
Look useful, but perhaps a bit overkill?<br>
<br>
> Perhaps we should try and include papercut, but I am trying to<br>
> introduce finished blocks of code, rather then half blocks.<br>
<br>
I am reluctant to introduce more dependencies, espesially those not<br>
already in Debian, as it make it harder to get the API implementation<br>
into Debian and other linux distributions.<br>
<br>
What if we stick with TODO for now, and consider transforming them to<br>
the papercut notation when we have a more complete picture?<br>
<br>
-- <br>
Happy hacking<br>
Petter Reinholdtsen<br>
_______________________________________________<br>
nikita-noark mailing list<br>
nikita-noark@nuug.no<br>
<a href="https://lists.nuug.no/mailman/listinfo/nikita-noark">https://lists.nuug.no/mailman/listinfo/nikita-noark</a><br>
</div>
</span></font>
</body>
</html>