[NUUG fiksgatami] [patch] Avoid unused include of RABX in index.cgi

Petter Reinholdtsen pere at hungry.com
Sat Mar 19 11:14:53 CET 2011


While trying to figure out why import.cgi do not work, I came across
the import of RABX in index.cgi, which seem to be unused.  The RABX
code seem to ony be used by the Tilma map code, so I suspect this
patch should be applied to clean up the include list.

Is this correct?

--- a/perllib/FixMyStreet/Map/Tilma/Original.pm
+++ b/perllib/FixMyStreet/Map/Tilma/Original.pm
@@ -16,6 +16,7 @@ use mySociety::GeoUtil;
 use mySociety::Locale;
 use mySociety::Web qw(ent NewURL);
 use Utils;
+use RABX;

 sub _ll_to_en {
     my ($lat, $lon) = @_;
--- a/web/index.cgi
+++ b/web/index.cgi
@@ -12,7 +12,6 @@ use Utils;
 use Encode;
 use Error qw(:try);
 use File::Slurp;
-use RABX;
 use CGI::Carp;
 use POSIX qw(strcoll);
 use URI::Escape;

Happy hacking,
-- 
Petter Reinholdtsen


More information about the fiksgatami mailing list